JSMF Discussbot 2.0.2

Home

Forum JSMF Discussbot 2.0.2

	Welcome, Guest. Please login or register. Did you miss your activation email? December 01, 2008, 02:31:48 PM

Joomla Forum

Joomla Hacks

Joomla-SMF Forum Support

Joomla-SMF 2.0.x (Moderators: -Wolverine, kai920)

JSMF Discussbot 2.0.2

0 Members and 1 Guest are viewing this topic.

« previous next »

Pages: [1] 2

Author

Topic: JSMF Discussbot 2.0.2 (Read 3379 times)

-Wolverine

Moderator
Joomla Guru

Karma: +376/-34
Offline

Offline

Posts: 3393

Lead Developer

JSMF Discussbot 2.0.2

« on: December 21, 2006, 12:24:25 PM »

I made some updates to the discussbot in order to resolve some reported bugs. It will be available in the remository soon and is available for download from this thread to registered users.

ChangeLog:

* 2.0.2
o Linkback missing index.php issue resolved(-Wolverine)
o Fixed problems with num_chars quoted(-Wolverine)
o HTML entity encoding for article, board, content, title fields(-Wolverine)


	Logged

Need help? Check Here First!
Get the JSMF User Guide
SEARCH this forum.

Livebox

Guest

Re: JSMF Discussbot 2.0.2

« Reply #1 on: December 21, 2006, 12:27:18 PM »

many thanks for for this update


	Logged

Cadinos

Joomla Newbie

Karma: +0/-0
Offline

Offline

Posts: 2

Re: JSMF Discussbot 2.0.2

« Reply #2 on: December 21, 2006, 01:02:57 PM »

Hi,
Great work!

But i found the following minor thing.
Line 597 is breaking the css-validator
I believe it should be
.dsc_bar{clear:both; display:block;}

instead of .dsc_bar{clear:both; display:block;};


	Logged

-Wolverine

Moderator
Joomla Guru

Karma: +376/-34
Offline

Offline

Posts: 3393

Lead Developer

Re: JSMF Discussbot 2.0.2

« Reply #3 on: December 21, 2006, 01:52:56 PM »

Quote from: Cadinos on December 21, 2006, 01:02:57 PM

Hi,
Great work!

But i found the following minor thing.
Line 597 is breaking the css-validator
I believe it should be
.dsc_bar{clear:both; display:block;}

instead of .dsc_bar{clear:both; display:block;};

thats right. Dunno who wrote that part but you are correct. Actually, this would work as well:

Code:

.dsc_bar{clear:both;display:block}


	Logged

Need help? Check Here First!
Get the JSMF User Guide
SEARCH this forum.

Mongoose

Joomla Newbie

Karma: +0/-0
Offline

Offline

Posts: 31

Re: JSMF Discussbot 2.0.2

« Reply #4 on: December 23, 2006, 06:22:03 AM »

Version 2.0.2 doesn't work with UTF-8 character set at all.
Previous version 2.0.1 works fine.


« Last Edit: December 23, 2006, 06:38:23 AM by Mongoose »	Logged

-Wolverine

Moderator
Joomla Guru

Karma: +376/-34
Offline

Offline

Posts: 3393

Lead Developer

Re: JSMF Discussbot 2.0.2

« Reply #5 on: December 23, 2006, 03:22:09 PM »

Quote from: Mongoose on December 23, 2006, 06:22:03 AM

Version 2.0.2 doesn't work with UTF-8 character set at all.
Previous version 2.0.1 works fine.

thats a bit vague, what doesn't work? Nothing, something, what? Gimme more detail


	Logged

Need help? Check Here First!
Get the JSMF User Guide
SEARCH this forum.

Mongoose

Joomla Newbie

Karma: +0/-0
Offline

Offline

Posts: 31

Re: JSMF Discussbot 2.0.2

« Reply #6 on: December 24, 2006, 02:52:26 AM »

Quote from: -Wolverine on December 23, 2006, 03:22:09 PM

thats a bit vague, what doesn't work? Nothing, something, what? Gimme more detail

Just doesn't work. Anywhere in the site bot strings {mos_smf_discuss:Some Board} appear in content as a plain text.
It's only for 2.0.2. Previous version works fine.


	Logged

-Wolverine

Moderator
Joomla Guru

Karma: +376/-34
Offline

Offline

Posts: 3393

Lead Developer

Re: JSMF Discussbot 2.0.2

« Reply #7 on: December 24, 2006, 09:59:40 AM »

did you publish it? Obviously if that was happening in my testing I wouldn't have released it. If you do have it published try uninstalling and reinstalling.


	Logged

Need help? Check Here First!
Get the JSMF User Guide
SEARCH this forum.

Mackavi

Joomla Newbie

Karma: +2/-0
Offline

Offline

Posts: 22

Re: JSMF Discussbot 2.0.2

« Reply #8 on: December 24, 2006, 10:22:51 AM »

Cheers for update - bot now links to forum message without problem but have lost the count indicating a post next - just reads 0.


	Logged

Mongoose

Joomla Newbie

Karma: +0/-0
Offline

Offline

Posts: 31

Re: JSMF Discussbot 2.0.2

« Reply #9 on: December 24, 2006, 11:11:08 AM »

Quote from: -Wolverine on December 24, 2006, 09:59:40 AM

did you publish it? Obviously if that was happening in my testing I wouldn't have released it. If you do have it published try uninstalling and reinstalling.

Are you kidding? Wink

I just change files over ftp, without reinstalling. 2.0.1 works, 2.0.2 doesn't.


	Logged

-Wolverine

Moderator
Joomla Guru

Karma: +376/-34
Offline

Offline

Posts: 3393

Lead Developer

Re: JSMF Discussbot 2.0.2

« Reply #10 on: December 24, 2006, 11:20:21 AM »

Quote from: Mackavi on December 24, 2006, 10:22:51 AM

Cheers for update - bot now links to forum message without problem but have lost the count indicating a post next - just reads 0.

always reads 0, or just the first post? SMF provides that number, first post is not counted as a reply, which is what the number indicates, number of replies.


	Logged

Need help? Check Here First!
Get the JSMF User Guide
SEARCH this forum.

Mongoose

Joomla Newbie

Karma: +0/-0
Offline

Offline

Posts: 31

Re: JSMF Discussbot 2.0.2

« Reply #11 on: December 24, 2006, 03:03:46 PM »

htmlentities and html_entity_decode php-functions make incorrect output for UTF-8 encoded strings.
I've rewrite some strings like this:

Code:

$default_discuss = htmlentities(html_entity_decode($botParams->get( 'default_discuss', '' ),ENT_QUOTES,'UTF-8'),ENT_QUOTES,'UTF-8'); //make sure board is url encoded
$title_prefix = htmlentities(html_entity_decode($botParams->get( 'title_prefix', '' ),ENT_QUOTES,'UTF-8'),ENT_QUOTES,'UTF-8');
$category_prefix = htmlentities(html_entity_decode($botParams->get( 'category_prefix', '' ),ENT_QUOTES,'UTF-8'),ENT_QUOTES,'UTF-8');
$linkback_prefix = htmlentities(html_entity_decode($botParams->get( 'linkback_prefix', '' ),ENT_QUOTES,'UTF-8'),ENT_QUOTES,'UTF-8');
$link_text = htmlentities(html_entity_decode($botParams->get( 'link_text', '' ),ENT_QUOTES,'UTF-8'),ENT_QUOTES,'UTF-8');

I have no experience with PHP, but it works.


« Last Edit: December 24, 2006, 03:13:31 PM by Mongoose »	Logged

-Wolverine

Moderator
Joomla Guru

Karma: +376/-34
Offline

Offline

Posts: 3393

Lead Developer

Re: JSMF Discussbot 2.0.2

« Reply #12 on: December 24, 2006, 03:31:09 PM »

unless I pass the char encoding to the function, but then that may break normal ISO encoded strings... which is the majority since J! 1.0.x does not support UTF-8 by default. So what to do, I guess I will try to rework this without using those functions.


	Logged

Need help? Check Here First!
Get the JSMF User Guide
SEARCH this forum.

-Wolverine

Moderator
Joomla Guru

Karma: +376/-34
Offline

Offline

Posts: 3393

Lead Developer

Re: JSMF Discussbot 2.0.2

« Reply #13 on: December 24, 2006, 04:05:28 PM »

try this and tell me if it works, its just the php file, upload via ftp


	Logged

Need help? Check Here First!
Get the JSMF User Guide
SEARCH this forum.

Mongoose

Joomla Newbie

Karma: +0/-0
Offline

Offline

Posts: 31

Re: JSMF Discussbot 2.0.2

« Reply #14 on: December 24, 2006, 04:36:52 PM »

Yes, it works. Thanks!

BTW I've found one more bug. When {mosimage} bot is in the start of the article, created forum message has something similar to this:

Code:

[url=http://operafan.net/content/view/206/40/]Opera будет сотрудничать с Samsung[/url]
[quote]://operafan.net/images/stories/samsung_logo.Сегодня норвежская компания Opera Software [url=http://www.opera.com/pressreleases/en/2006/12/21/]объявила[/url] о. . .[/quote]

The same bug with a big list <li> which is longer than the quote (and becomes cutted in the middle).


« Last Edit: December 24, 2006, 04:40:28 PM by Mongoose »	Logged

Pages: [1] 2

« previous next »

Jump to: