Home arrow Forum JSMF 2.0 RC1 released
  Welcome, Guest. Please login or register.
Did you miss your activation email?
December 05, 2008, 01:01:58 PM
Home New Posts Search Calendar


Login with username, password and session length
+  Joomla Forum
|-+  Joomla Hacks
| |-+  Joomla-SMF Forum Support
| | |-+  Joomla-SMF 2.0.x (Moderators: -Wolverine, kai920)
| | | |-+  JSMF 2.0 RC1 released
0 Members and 1 Guest are viewing this topic. « previous next »
Pages: 1 ... 6 7 [8] Go Down Print
Author Topic: JSMF 2.0 RC1 released  (Read 26526 times)
pk
Joomla Newbie
*

Karma: +1/-0
Offline Offline

Posts: 10


View Profile
Re: JSMF 2.0 RC1 released
« Reply #105 on: October 28, 2006, 05:34:30 AM »

Hi Tijntje,

Seems like a problem with template you are using. Maybe there are some tags that are not closed and this is the reason that some of the elements are displayed wrong way?
I had similar problem with my joomla template and I found one tag inappropriatelly closed. When I fixed it everything was working normal.

In general this should not be a problem of the bridge as it does not modify the SMF code.
Logged
-Wolverine
Moderator
Joomla Guru
*****

Karma: +376/-34
Offline Offline

Posts: 3393


Lead Developer


View Profile WWW
Re: JSMF 2.0 RC1 released
« Reply #106 on: October 28, 2006, 11:41:32 AM »

I'm using CB login module, but the problem is with logging in from SMF.
Just a little description of test scenario that I can do on my page:
1. I'm inside the forum, then I'm logging in from SMF -> and I'm redirected to main page, variable $setLocation is ''
2. I'm inside the forum, then I'm logging in from CB -> I stay where I was, variable $setLocation is set to the right page/thread
3. I commented the code I wrote you previously & I'm inside the forum, then I'm logging in from SMF -> I'm still in the forum, variable $setLocation is set to the right page/thread

It seems that the code spoils my redirection.
thanks for the kick in the butt!  I took another look and it seems I was approaching this security problem wrong and you were right that this code could be incorrectly clearing forum locations.  I have reworked the code and it seems to be behaving better.  It will be included in JSMF 2.0RC2
Logged

Need help?  Check Here First!
Get the JSMF User Guide
SEARCH this forum.
pk
Joomla Newbie
*

Karma: +1/-0
Offline Offline

Posts: 10


View Profile
Re: JSMF 2.0 RC1 released
« Reply #107 on: October 28, 2006, 03:05:58 PM »

thanks for the kick in the butt!  I took another look and it seems I was approaching this security problem wrong and you were right that this code could be incorrectly clearing forum locations.  I have reworked the code and it seems to be behaving better.  It will be included in JSMF 2.0RC2

No problem.
Can you tell me when can we expect RC2? Or maybe you can send me correct piece of code so I will replace the "if clause" I have with whatever you will send me?
Logged
Tijntje
Joomla Newbie
*

Karma: +0/-2
Offline Offline

Posts: 36



View Profile WWW
Re: JSMF 2.0 RC1 released
« Reply #108 on: October 29, 2006, 08:51:04 AM »

Hi Tijntje,

Seems like a problem with template you are using. Maybe there are some tags that are not closed and this is the reason that some of the elements are displayed wrong way?
I had similar problem with my joomla template and I found one tag inappropriatelly closed. When I fixed it everything was working normal.

In general this should not be a problem of the bridge as it does not modify the SMF code.
Thanks for your reply
Why is it only with a quote and not a reply for instance?
If it is in my template do you mean the index.php from the template?
The other strange thing is that when I copy the Link Location from my browser and paste it into a new window it works like it should.
« Last Edit: October 29, 2006, 08:53:28 AM by Tijntje » Logged
Livebox
Guest
Re: JSMF 2.0 RC1 released
« Reply #109 on: October 29, 2006, 08:56:27 AM »

Yes this can be in the Index.php of your template

example when you open a function you also have to close it.
A simple example
<td <--open tag
</td> <--Close tag
Logged
onecha
Joomla Newbie
*

Karma: +0/-0
Offline Offline

Posts: 21


Make Poverty History! www.gago.info


View Profile WWW
Re: JSMF 2.0 RC1 released
« Reply #110 on: October 29, 2006, 10:15:39 AM »

GREAT!!!

It works perfectly!!!

THANKS A LOT!!

PS I was just about going to change your brigde for the Orstio´s one!

THANKS AGAIN!
« Last Edit: October 29, 2006, 10:18:09 AM by JM Gago » Logged

José Manuel Gago Onecha

www.Gago.Info MAKE POVERTY HISTORY!
-Wolverine
Moderator
Joomla Guru
*****

Karma: +376/-34
Offline Offline

Posts: 3393


Lead Developer


View Profile WWW
Re: JSMF 2.0 RC1 released
« Reply #111 on: October 29, 2006, 02:02:20 PM »

JSMF 2.0RC2 is almost released, but I had to make a change to the caching today so I need to have the test team run it through its paces before I unleash the havoc Wink
Logged

Need help?  Check Here First!
Get the JSMF User Guide
SEARCH this forum.
Tijntje
Joomla Newbie
*

Karma: +0/-2
Offline Offline

Posts: 36



View Profile WWW
Re: JSMF 2.0 RC1 released
« Reply #112 on: October 30, 2006, 02:36:25 AM »

Yes this can be in the Index.php of your template

example when you open a function you also have to close it.
A simple example
<td <--open tag
</td> <--Close tag

Oke thanks,
I tried it with 3 different templates:
1. madeyourweb
2. p3p70bf2_1
3. rhuk_solarflare_ii
They all have the same problem.

I've checked the entire template and didn't find any problems.
With the old version of the bridge I didn't have any problem.

Oke did some futher testing and changed the template of SMF. Normally I use the default template of SMF. The only theme were it did work correctly was Dark Day.
If there is anyone who knows were to look I would really appreciate it.
« Last Edit: October 30, 2006, 07:39:58 AM by Tijntje » Logged
Livebox
Guest
Re: JSMF 2.0 RC1 released
« Reply #113 on: October 30, 2006, 11:28:30 AM »

Joomla and SMF templates are using the same Class Id’s . What you can do is: You can look for the duplicate Class Id’s in your templates. and you can rename them in one of the templates. I renamed the most in the Joomla template.


I used for the Webdeveloper toolbar for Firefox. This is really a great tool for finding these things.

Example of duplicate Class Id’s. (the footer Class Id)

Joomla footer (index.php)
Code:
<div class="topnav" id="footer">
<?php mosLoadModules('footer', -1); ?>
<?php include_once( $mosConfig_absolute_path .'/includes/footer.php' ); ?>
</div>

SMF footer (index.template.php)
Code:
<div id="footer">', theme_copyright(), '</div>

I renamed the footer ID from the Joomla template also ajust the Css file. and it works for me.
Logged
-Wolverine
Moderator
Joomla Guru
*****

Karma: +376/-34
Offline Offline

Posts: 3393


Lead Developer


View Profile WWW
Re: JSMF 2.0 RC1 released
« Reply #114 on: October 30, 2006, 12:15:04 PM »

good point livebox.  There should *only* be one element with a given id name.  You should never use the same id twice in your html.  Obviously since J! and SMF are two separate systems it is possible you will have duplicate elements with the same id.
Logged

Need help?  Check Here First!
Get the JSMF User Guide
SEARCH this forum.
Tijntje
Joomla Newbie
*

Karma: +0/-2
Offline Offline

Posts: 36



View Profile WWW
Re: JSMF 2.0 RC1 released
« Reply #115 on: October 30, 2006, 02:38:57 PM »

Joomla and SMF templates are using the same Class Id’s . What you can do is: You can look for the duplicate Class Id’s in your templates. and you can rename them in one of the templates. I renamed the most in the Joomla template.


I used for the Webdeveloper toolbar for Firefox. This is really a great tool for finding these things.

Example of duplicate Class Id’s. (the footer Class Id)

Joomla footer (index.php)
Code:
<div class="topnav" id="footer">
<?php mosLoadModules('footer', -1); ?>
<?php include_once( $mosConfig_absolute_path .'/includes/footer.php' ); ?>
</div>

SMF footer (index.template.php)
Code:
<div id="footer">', theme_copyright(), '</div>

I renamed the footer ID from the Joomla template also ajust the Css file. and it works for me.

Hi thanks for the reply, but that can't be the problem.
I build a check in the Joomla template.
When my forum is shown I don't show any menu's on the left side. When this happens I don't include the Joomla CSS but only the SMF template CCS. I included some of the CSS id's from the Joomla template in the SMF template.
Logged
Livebox
Guest
Re: JSMF 2.0 RC1 released
« Reply #116 on: October 30, 2006, 03:10:10 PM »

How did you build in the check. Did you check it with the Webdeveloper toolbar witch Css files are loaded. Wink

I had to rewrite a lot of Css code to get my board done. I am still working on it Tongue
« Last Edit: October 30, 2006, 03:12:04 PM by Livebox » Logged
Tijntje
Joomla Newbie
*

Karma: +0/-2
Offline Offline

Posts: 36



View Profile WWW
Re: JSMF 2.0 RC1 released
« Reply #117 on: October 31, 2006, 02:55:58 AM »

How did you build in the check. Did you check it with the Webdeveloper toolbar witch Css files are loaded. Wink

I had to rewrite a lot of Css code to get my board done. I am still working on it Tongue
I did the following in my template index.php:
Code:
if ( mosCountModules( 'left' ) > 0) {
$forum = 0;
}
else{
$forum = 1;
}
Code:
<?php
   if ($forum == 0){
   ?>

<link href="<?php echo $mosConfig_live_site;?>/templates/p3p70bf2_1/css/template_css.css" rel="stylesheet" type="text/css"/>
  <?php
   }
   ?>


I check if there are any menu's on the left if not the forum is loaded and I  don't load the css from joomla.

And I checked with Webdeveloper Toolbar and only the Print.css and Style.css from SMF are loaded.

But the strange thing is when I copy the link to qoute and open that in a new window all works fine.

And I never had the problem with the old bridge.
Logged
Pages: 1 ... 6 7 [8] Go Up Print 
« previous next »
Jump to:  



Login with username, password and session length

Powered by MySQL Powered by PHP Joomla Forum | Powered by SMF 1.1 RC1.
© 2001-2005, Lewis Media. All Rights Reserved.
Joomla Bridge by JoomlaHacks.com
Valid XHTML 1.0! Valid CSS!

Joomla Hacks is a Joomla Components, Joomla Modules, Joomla Templates, & Joomla Mambots resource portal. None of the text or images in this public website may be copied without the expressed written consent of the authors. Copyright 2005 by JoomlaHacks.com. Powered by Joomla. All rights reserved.
Terms of Use
Joomla Hacks



Joomla Hacks
German Lang French Lang Italian Lang Spanish Lang Japanese Lang Chinese Lang
i-Vibe.com
Search Contact About Advertise Blogs Topsites Submit News Register Login