Home arrow Forum Joomap plugin shows no topics if time is missing
  Welcome, Guest. Please login or register.
Did you miss your activation email?
December 05, 2008, 12:58:19 PM
Home New Posts Search Calendar


Login with username, password and session length
+  Joomla Forum
|-+  Joomla Hacks
| |-+  Joomla-SMF Forum Support
| | |-+  Joomla-SMF 2.0.x (Moderators: -Wolverine, kai920)
| | | |-+  Joomap plugin shows no topics if time is missing
0 Members and 1 Guest are viewing this topic. « previous next »
Pages: [1] Go Down Print
Author Topic: Joomap plugin shows no topics if time is missing  (Read 1254 times)
Patrick Johnson
Joomla Newbie
*

Karma: +1/-0
Offline Offline

Posts: 43


View Profile
Joomap plugin shows no topics if time is missing
« on: October 22, 2006, 11:49:22 PM »

Hi,

If the maximum aging time is not given in the Joomap configuration for the SMF plugin, it does not dump any topics.

Is this the intended operation ?

Change the code as follows to dump ALL topics if the time is not given.

Line 252:
Code:
/* dump all topics if time not given
*/
if( $jsmfConfig->jm_from ) {
if ($jsmfConfig->jm_sticky) {
$query .= "\n AND (m.posterTime > {$topics_from} OR t.isSticky = 1)";
} else {
$query .= "\n AND m.posterTime > {$topics_from}";
}
}

Thanks,
Patrick
Logged
-Wolverine
Moderator
Joomla Guru
*****

Karma: +376/-34
Offline Offline

Posts: 3393


Lead Developer


View Profile WWW
Re: Joomap plugin shows no topics if time is missing
« Reply #1 on: October 23, 2006, 10:39:24 AM »

that is so scary I don't even know what to say.  On a site with a lot of topics(mine has over 7k) you will absolutely *kill* your server.  The real reason this happens is this bit of code at line 238.

Code:
        if (!is_numeric($jsmfConfig->jm_from)) {
            $jsmfConfig->jm_from = 0;
        }
Basically, if you don't have a value in the configuration field or if it isn't numeric then I set it to 0. 

I wouldn't recommend the code you posted for server load reasons.  But it is valid.  Good luck.
Logged

Need help?  Check Here First!
Get the JSMF User Guide
SEARCH this forum.
Patrick Johnson
Joomla Newbie
*

Karma: +1/-0
Offline Offline

Posts: 43


View Profile
Re: Joomap plugin shows no topics if time is missing
« Reply #2 on: October 23, 2006, 01:17:19 PM »

I see your point.  I was working with a prelaunch site, where there aren't any "new" messages.  I will revert my change when we launch and the forum picks up activity.

Thanks,
Patrick
Logged
Pages: [1] Go Up Print 
« previous next »
Jump to:  



Login with username, password and session length

Powered by MySQL Powered by PHP Joomla Forum | Powered by SMF 1.1 RC1.
© 2001-2005, Lewis Media. All Rights Reserved.
Joomla Bridge by JoomlaHacks.com
Valid XHTML 1.0! Valid CSS!

Joomla Hacks is a Joomla Components, Joomla Modules, Joomla Templates, & Joomla Mambots resource portal. None of the text or images in this public website may be copied without the expressed written consent of the authors. Copyright 2005 by JoomlaHacks.com. Powered by Joomla. All rights reserved.
Terms of Use
Joomla Hacks



Joomla Hacks
German Lang French Lang Italian Lang Spanish Lang Japanese Lang Chinese Lang
Search Contact About Advertise Blogs Topsites Submit News Register Login