Can't patch index.php version 1.0.10

Home

Forum Can't patch index.php version 1.0.10

	Welcome, Guest. Please login or register. Did you miss your activation email? December 01, 2008, 08:46:58 PM

Joomla Forum

Joomla Hacks

Joomla-SMF Forum Support

Joomla-SMF 1.1.x (Moderators: -Wolverine, kai920)

Can't patch index.php version 1.0.10

0 Members and 1 Guest are viewing this topic.

« previous next »

Pages: 1 [2] 3

Author

Topic: Can't patch index.php version 1.0.10 (Read 7273 times)

Stefan Gabardi

Joomla Newbie

Karma: +1/-0
Offline

Offline

Posts: 4

Re: Can't patch index.php version 1.0.10

« Reply #15 on: June 27, 2006, 02:34:19 AM »

Hi guys!

In 1.0.10 the codeparts for mosGetParams has changed to prevent SQL-Injections.

For explanation:

Until 1.0.9 the code for mosGetParams in the index.php looked like this:

Code:

$message = mosGetParam( $_POST, 'message', 0 );

In 1.0.10 this has changed to:

Code:

$message = intval( mosGetParam( $_POST, 'message', 0 ) );

So I suppose, that the patching script of the bridge is not able to find the parts of the code to be patched for a proper working system.

I patched my 1.0.10 index.php by hand, and it works perfect. I attached my "hand-patched" one to this post.

Stefan
joomla-austria.at

//EDIT: forgot the codepieces Roll Eyes


« Last Edit: June 27, 2006, 04:06:37 AM by Stefan Gabardi »	Logged

joomla-austria.at | gabardi.at

Kilian

Joomla Newbie

Karma: +0/-0
Offline

Offline

Posts: 11

Re: Can't patch index.php version 1.0.10

« Reply #16 on: June 27, 2006, 03:04:59 AM »

Thanks Stefan for your hand-patched version 1.0.10! It works nice on my site too.

Best regards
KiCR


	Logged

Yuriy Boev

Joomla Newbie

Karma: +0/-0
Offline

Offline

Posts: 2

Re: Can't patch index.php version 1.0.10

« Reply #17 on: June 27, 2006, 05:56:16 AM »

10 a lot man. You rulez Cheesy


	Logged

-Wolverine

Moderator
Joomla Guru

Karma: +376/-34
Offline

Offline

Posts: 3393

Lead Developer

Re: Can't patch index.php version 1.0.10

« Reply #18 on: June 27, 2006, 11:29:42 AM »

I was just about to release JSMF 1.1.4 however there are changes to the index.php in J! 1.0.10. So I am going to incorporate those changes into 1.1.4 and release it, hopefully later today. Thanks for everyone's patience.


	Logged

Need help? Check Here First!
Get the JSMF User Guide
SEARCH this forum.

Jeremy

Joomla Newbie

Karma: +1/-0
Offline

Offline

Posts: 31

Re: Can't patch index.php version 1.0.10

« Reply #19 on: June 27, 2006, 12:00:08 PM »

Quote from: -Wolverine on June 27, 2006, 11:29:42 AM

ROCK ON! Cheers to Wolverine!


	Logged

Gustavo

Joomla Newbie

Karma: +0/-0
Offline

Offline

Posts: 9

Re: Can't patch index.php version 1.0.10

« Reply #20 on: June 27, 2006, 04:22:03 PM »

Ive tryed both index.php fixes posted here but this one still gives error:

Patch SMF Source Files (Note: Unpatch before upgrading SMF or installing mod.)

Failed: Code to be patched not found in file:

I have 1.0.10 joomla too. Is this why I also see a blank page when I add the forum to my mainmenu and click on it?


	Logged

Gary Raduns

Joomla Newbie

Karma: +6/-0
Offline

Offline

Posts: 36

Re: Can't patch index.php version 1.0.10

« Reply #21 on: June 27, 2006, 04:53:23 PM »

Gustavo, check your SMF path in configuration. Also, it will not auto-patch if you are not using SMF 1.1 RC2


	Logged

Imago

Joomla Newbie

Karma: +5/-1
Offline

Offline

Posts: 43

Re: Can't patch index.php version 1.0.10

« Reply #22 on: June 27, 2006, 04:57:04 PM »

Thanks to Stefan indeed, and don't forget to remove http://www.joomla-austria.at from the joomlahacks section, otherwise users would land in Austria when logging out. Wink


	Logged

Gustavo

Joomla Newbie

Karma: +0/-0
Offline

Offline

Posts: 9

Re: Can't patch index.php version 1.0.10

« Reply #23 on: June 27, 2006, 04:58:28 PM »

Joomla-SMF_1_1_3. the path is correct Sad

Its the right path because it doesnt show the red text error underneath and it reads "installed"


« Last Edit: June 27, 2006, 05:03:06 PM by Gustavo »	Logged

-Wolverine

Moderator
Joomla Guru

Karma: +376/-34
Offline

Offline

Posts: 3393

Lead Developer

Re: Can't patch index.php version 1.0.10

« Reply #24 on: June 27, 2006, 04:59:04 PM »

a quick update, there is a problem with the latest SEF and the quick moderation links necessitating a further modification. I am still aiming for a release tonight.


	Logged

Need help? Check Here First!
Get the JSMF User Guide
SEARCH this forum.

Gustavo

Joomla Newbie

Karma: +0/-0
Offline

Offline

Posts: 9

Re: Can't patch index.php version 1.0.10

« Reply #25 on: June 27, 2006, 05:04:26 PM »

btw, I also see its creating type "Component-" with the title "Forum" in my main menu.


	Logged

Stefan Gabardi

Joomla Newbie

Karma: +1/-0
Offline

Offline

Posts: 4

Re: Can't patch index.php version 1.0.10

« Reply #26 on: June 27, 2006, 05:24:22 PM »

Quote from: Imago on June 27, 2006, 04:57:04 PM

Thanks to Stefan indeed, and don't forget to remove http://www.joomla-austria.at from the joomlahacks section, otherwise users would land in Austria when logging out. Wink

Thanks for the tip, forgot to mention that Wink


	Logged

joomla-austria.at | gabardi.at

Fredto

Joomla Newbie

Karma: +0/-0
Offline

Offline

Posts: 1

Re: Can't patch index.php version 1.0.10

« Reply #27 on: June 30, 2006, 03:02:25 PM »

Odd.
I still have the same problem (Failed: Code to be patched not found in file: .../index.php).

I tried the 2 files generously offered by the people in this topic with no success.

I even have Notice: Constant WIRELESS already defined in ...forum/index.php on line 78 on the mainpage.

Any thoughts?

EDIT:
By the way, the forum is integrated fine, it's just that it keeps displaying this thing on top of the page and that I don't like having errors in my stuff Wink

EDIT 2:
I have the latest versions of everything, Joomla, SMF and the bridge (downloaded everything yesterday morning).


« Last Edit: July 01, 2006, 08:25:01 AM by Fredto »	Logged

Darren

Joomla Newbie

Karma: +0/-0
Offline

Offline

Posts: 6

Re: Can't patch index.php version 1.0.10

« Reply #28 on: July 11, 2006, 12:32:46 AM »

I have the following:
Joomla 1.0.10
SMF 1.1RC2
CB 1.0 Stable
JSMF 1.1.4

I get the same blank page as Gustavo on vmset.com/index.php source code looks like:

Code:

On the wrapped com_smf page I get this much shown:

Code:

<?xml version="1.0" encoding="iso-8859-1"?><!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>GarlandGuru - Bringing out your inner princess - Garland Gathering - Index</title>
<meta name="description" content="Joomla - the dynamic portal engine and content management system, Garland Gathering - Index." />
<meta name="keywords" content="Joomla, joomla, Garland, Gathering, Index" />
<meta name="Generator" content="Joomla! - Copyright (C) 2005 - 2006 Open Source Matters. All rights reserved." />
<meta name="robots" content="index, follow" />
<link rel="shortcut icon" href="http://vmset.com/images/favicon.ico" />
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<link href="http://vmset.com/templates/rhuk_solarflare_ii/css/template_css.css" rel="stylesheet" type="text/css"/>
</head>
<body>

<div align="center">
<table border="0" cellpadding="0" cellspacing="0" width="808">
<tr>
<td class="outline">
<div id="buttons_outer">
<div id="buttons_inner">
<div id="buttons">
</div>
</div>

</div>
<div id="search_outer">
<div id="search_inner">

<form action="index.php?option=com_search" method="get">
<div class="search">
<input name="searchword" id="mod_search_searchword" maxlength="20" alt="search" class="inputbox" type="text" size="20" value="search..." onblur="if(this.value=='') this.value='search...';" onfocus="if(this.value=='search...') this.value='';" /> </div>

<input type="hidden" name="option" value="com_search" />
<input type="hidden" name="Itemid" value="" />

</form> </div>
</div>
<div class="clr"></div>
<div id="header_outer">
<div id="header">
 
</div>
<div id="top_outer">
<div id="top_inner">

<div class="moduletable">

I have been running fine but this is a clean install I am doing for a client as I bring them to my new server.
I am running
Apache 2.0.54 (Fedora)
PHP 5.0.4-10.5
MySQL 4.1.20-1.FC4.1
RedHat Linux FC4


	Logged

Darren

Joomla Newbie

Karma: +0/-0
Offline

Offline

Posts: 6

Re: Can't patch index.php version 1.0.10

« Reply #29 on: July 11, 2006, 01:47:48 AM »

I was looking closer at the index.php file. from lines 237-249 the code is this:

Code:

if ($path = $mainframe->getPath( 'front' )) {
$task = strval( mosGetParam( $_REQUEST, 'task', '' ) );
$ret = mosMenuCheck( $Itemid, $option, $task, $gid );

if ($ret) {
require_once( $path );
} else {
mosNotAuth();
}
} else {
header( 'HTTP/1.0 404 Not Found' );
echo _NOT_EXIST;
}

It is this code specifically that throws the first monkey wrench as I am stepping through. It appears that $ret is not loaded correctly to me. First pass at this review and many hours looking this over by this point.

Code:

if ($ret) {
require_once( $path );
} else {
mosNotAuth();
}


	Logged

Pages: 1 [2] 3

« previous next »

Jump to: