In _isValidUser of smf.class.php (jsmf 2.0.2.1)
$mos needs to be initialized to false before the two
if ((strpos($data->password, ':') === true))
clauses that reference it, because otherwise the variable will be out of scope when it is checked after the initial if clauses. I'm pretty sure the original code of inner if clauses in first part of those clauses can be shortened to just
if ($hash == $cryptpass) {
//CORRECT password
$mos = true;
}
after this change, because it is pointless to set variable to its default value second time.
Forum 







